Quantcast

Bacula Release 7.4.6

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bacula Release 7.4.6

Kern Sibbald

Bacula Release 7.4.6

We are pleased to announce that we have just released Bacula version 7.4.6 to Source Forge and to the Bacula.org website.

This version is a minor bug fix release that fixes a number of bugs in the prior release as well as some long standing bugs.

If you are already running Bacula version 7.4.0 or greater, it is not urgent to upgrade unless you find a problem you are experiencing on the list of fixes (see ReleaseNotes below). There is no database update required from any prior 7.4.x version, but as usual all Storage Daemons must be updated to the same version as your Director (presumably 7.4.5).

As a reminder, the Windows File Daemon is available for download on the www.bacula.org web site for personal use. Since there are no updates to the Windows FD, version 7.4.6 does not exist. Consequently, please use the Windows FD version 7.4.4.

I have now found a replacement for WPDM (WordPress Download Manager), which suddenly stopped working, and the Windows binaries for 7.4.4 are loaded as well as the source for 7.4.6. In the next few days, I will also reload a few older Bacula versions.

Thank you for using Bacula.

Please find the Release Notes at the end of this email.

===================================================

Do you like working with Bacula?  Or do you want to work for a company that makes massive contributions to Open Source?  If so, Bacula Systems is growing and open positions.  Please go to:

   https://www.baculasystems.com/company/careers

to see the currently open positions.

===================================================

Release Notes for Bacula 7.4.6

Release Version 7.4.6

This is a bug fix release, which hopefully corrects a seg fault on OpenBSD due to the nex ACL/XATTR code, and it also fixes the large number of tape mount messages that are repeated at 5 minute intervals due to a bug in the poll code. Various small fixes for FreeBSD.

Please note, the signature hash files (.sig) for the source code was previously SHA1. For this and future releases we have changed it to be SHA256.

10Mar17
– Fix bug #2271 where poll interval causes tape mount message to repeat
– Attempt to fix IPV6 not configured
– Possible fix for acl seg fault on OpenBSD where no acl code defined
– Change release digest from SHA1 to SHA256
– Fix getnameinfo() for FreeBSD fixes bug #2083

Bugs fixed/closed since last release:
2083 2271


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Stuart Henderson
On 2017/03/12 09:42, Kern Sibbald wrote:
> This is a bug fix release, which hopefully corrects a seg fault on
> OpenBSD due to the nex ACL/XATTR code

This now results in the following from the FD, and I didn't see a
config method to disable ACL/XATTR backups.

  Fatal error: ACL backup requested but not configured in Bacula.
  Fatal error: XATTR backup requested but not configured in Bacula.

I have been successfully running 7.4.5 after checking for null
as I suggested in my previous mail, specifically

--- src/filed/backup.c.orig Thu Feb 16 16:21:07 2017
+++ src/filed/backup.c Thu Feb 16 16:28:49 2017
@@ -163,12 +163,14 @@ bool blast_data_to_storage_daemon(JCR *jcr, char *addr
       jcr->setJobStatus(JS_ErrorTerminated);
    }
 
-   if (jcr->xacl->get_acl_nr_errors() > 0) {
-      Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
-   }
+   if (jcr->xacl) {
+      if (jcr->xacl->get_acl_nr_errors() > 0) {
+         Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
+      }
 
-   if (jcr->xacl->get_xattr_nr_errors() > 0) {
-      Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
+      if (jcr->xacl->get_xattr_nr_errors() > 0) {
+         Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
+      }
    }
 
    /* Delete or keep snapshots */


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Kern Sibbald
Hello Stuart,

Thanks for the feedback.  Well, the results are not what I expected.  I
will think about it a bit, but I think I am going to fall back to your
solution.

Thanks,
Kern

On 03/12/2017 06:06 PM, Stuart Henderson wrote:

> On 2017/03/12 09:42, Kern Sibbald wrote:
>> This is a bug fix release, which hopefully corrects a seg fault on
>> OpenBSD due to the nex ACL/XATTR code
> This now results in the following from the FD, and I didn't see a
> config method to disable ACL/XATTR backups.
>
>    Fatal error: ACL backup requested but not configured in Bacula.
>    Fatal error: XATTR backup requested but not configured in Bacula.
>
> I have been successfully running 7.4.5 after checking for null
> as I suggested in my previous mail, specifically
>
> --- src/filed/backup.c.orig Thu Feb 16 16:21:07 2017
> +++ src/filed/backup.c Thu Feb 16 16:28:49 2017
> @@ -163,12 +163,14 @@ bool blast_data_to_storage_daemon(JCR *jcr, char *addr
>         jcr->setJobStatus(JS_ErrorTerminated);
>      }
>  
> -   if (jcr->xacl->get_acl_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> -   }
> +   if (jcr->xacl) {
> +      if (jcr->xacl->get_acl_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> +      }
>  
> -   if (jcr->xacl->get_xattr_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      if (jcr->xacl->get_xattr_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      }
>      }
>  
>      /* Delete or keep snapshots */
>
>
> ------------------------------------------------------------------------------
> Announcing the Oxford Dictionaries API! The API offers world-renowned
> dictionary content that is easy and intuitive to access. Sign up for an
> account today to start using our lexical data to power your apps and
> projects. Get started today and enter our developer competition.
> http://sdm.link/oxford
> _______________________________________________
> Bacula-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/bacula-devel
>


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Wanderlei Huttel
Good Morning

This problem in ACL is only in OpenBSD or in any system?


Best regards

Wanderlei Hüttel

2017-03-13 3:21 GMT-03:00 Kern Sibbald <[hidden email]>:
Hello Stuart,

Thanks for the feedback.  Well, the results are not what I expected.  I
will think about it a bit, but I think I am going to fall back to your
solution.

Thanks,
Kern

On 03/12/2017 06:06 PM, Stuart Henderson wrote:
> On 2017/03/12 09:42, Kern Sibbald wrote:
>> This is a bug fix release, which hopefully corrects a seg fault on
>> OpenBSD due to the nex ACL/XATTR code
> This now results in the following from the FD, and I didn't see a
> config method to disable ACL/XATTR backups.
>
>    Fatal error: ACL backup requested but not configured in Bacula.
>    Fatal error: XATTR backup requested but not configured in Bacula.
>
> I have been successfully running 7.4.5 after checking for null
> as I suggested in my previous mail, specifically
>
> --- src/filed/backup.c.orig   Thu Feb 16 16:21:07 2017
> +++ src/filed/backup.c        Thu Feb 16 16:28:49 2017
> @@ -163,12 +163,14 @@ bool blast_data_to_storage_daemon(JCR *jcr, char *addr
>         jcr->setJobStatus(JS_ErrorTerminated);
>      }
>
> -   if (jcr->xacl->get_acl_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> -   }
> +   if (jcr->xacl) {
> +      if (jcr->xacl->get_acl_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> +      }
>
> -   if (jcr->xacl->get_xattr_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      if (jcr->xacl->get_xattr_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      }
>      }
>
>      /* Delete or keep snapshots */
>
>
> ------------------------------------------------------------------------------
> Announcing the Oxford Dictionaries API! The API offers world-renowned
> dictionary content that is easy and intuitive to access. Sign up for an
> account today to start using our lexical data to power your apps and
> projects. Get started today and enter our developer competition.
> http://sdm.link/oxford
> _______________________________________________
> Bacula-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/bacula-devel
>


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Stuart Henderson
On 2017/03/13 08:07, Wanderlei Huttel wrote:
> Good Morning
>
> This problem in ACL is only in OpenBSD or in any system?

It will be any where Bacula doesn't have ACL/XATTR support. In the case
of OpenBSD the OS doesn't have ACL/XATTR so Bacula can't enable it there
at all.


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Phil Stracchino-2
On 03/13/17 07:18, Stuart Henderson wrote:
> On 2017/03/13 08:07, Wanderlei Huttel wrote:
>> Good Morning
>>
>> This problem in ACL is only in OpenBSD or in any system?
>
> It will be any where Bacula doesn't have ACL/XATTR support. In the case
> of OpenBSD the OS doesn't have ACL/XATTR so Bacula can't enable it there
> at all.

I'm seeing lots of:

Compiling verify_vol.c
"xacl.h", line 142: Warning: content hides XACL::content.
"xacl.h", line 168: Warning: content hides XACL::content.
"xacl.h", line 194: Warning: content hides XACL::content.


when compiling on Solaris 10.

Also in smaller quantities,

Compiling label.c
"label.c", line 490: Warning: jcr hides DCR::jcr.
"label.c", line 536: Warning: jcr hides DCR::jcr.
"label.c", line 573: Warning: jcr hides DCR::jcr.
3 Warning(s) detected.
Compiling lock.c
"lock.c", line 157: Warning: file hides DEVICE::file.
"lock.c", line 165: Warning: file hides DEVICE::file.
"lock.c", line 172: Warning: file hides DEVICE::file.
"lock.c", line 211: Warning: file hides DEVICE::file.
"lock.c", line 275: Warning: file hides DEVICE::file.
"lock.c", line 281: Warning: file hides DEVICE::file.
"lock.c", line 287: Warning: file hides DEVICE::file.
"lock.c", line 293: Warning: file hides DEVICE::file.
"lock.c", line 299: Warning: file hides DEVICE::file.
"lock.c", line 304: Warning: file hides DEVICE::file.
10 Warning(s) detected.


--
   Phil Stracchino
   Babylon Communications
   [hidden email]
   [hidden email]
   Landline: 603.293.8485

------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Kern Sibbald
In reply to this post by Wanderlei Huttel



On 03/13/2017 12:07 PM, Wanderlei Huttel wrote:
Good Morning

This problem in ACL is only in OpenBSD or in any system?

The problem exists on systems where we have not implemented any ACL code.  The code is currently implemented on Linux, FreeBSD, OSx, and Solaris.  On all other OSes, it will currently fail in some way.  I will release version 7.4.7 in the next day or two, which will fix the problem.

Best regards,
Kern


Best regards

Wanderlei Hüttel

2017-03-13 3:21 GMT-03:00 Kern Sibbald <[hidden email]>:
Hello Stuart,

Thanks for the feedback.  Well, the results are not what I expected.  I
will think about it a bit, but I think I am going to fall back to your
solution.

Thanks,
Kern

On 03/12/2017 06:06 PM, Stuart Henderson wrote:
> On 2017/03/12 09:42, Kern Sibbald wrote:
>> This is a bug fix release, which hopefully corrects a seg fault on
>> OpenBSD due to the nex ACL/XATTR code
> This now results in the following from the FD, and I didn't see a
> config method to disable ACL/XATTR backups.
>
>    Fatal error: ACL backup requested but not configured in Bacula.
>    Fatal error: XATTR backup requested but not configured in Bacula.
>
> I have been successfully running 7.4.5 after checking for null
> as I suggested in my previous mail, specifically
>
> --- src/filed/backup.c.orig   Thu Feb 16 16:21:07 2017
> +++ src/filed/backup.c        Thu Feb 16 16:28:49 2017
> @@ -163,12 +163,14 @@ bool blast_data_to_storage_daemon(JCR *jcr, char *addr
>         jcr->setJobStatus(JS_ErrorTerminated);
>      }
>
> -   if (jcr->xacl->get_acl_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> -   }
> +   if (jcr->xacl) {
> +      if (jcr->xacl->get_acl_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld acl errors while doing backup\n"), jcr->xacl->get_acl_nr_errors());
> +      }
>
> -   if (jcr->xacl->get_xattr_nr_errors() > 0) {
> -      Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      if (jcr->xacl->get_xattr_nr_errors() > 0) {
> +         Jmsg(jcr, M_WARNING, 0, _("Had %ld xattr errors while doing backup\n"), jcr->xacl->get_xattr_nr_errors());
> +      }
>      }
>
>      /* Delete or keep snapshots */
>
>
> ------------------------------------------------------------------------------
> Announcing the Oxford Dictionaries API! The API offers world-renowned
> dictionary content that is easy and intuitive to access. Sign up for an
> account today to start using our lexical data to power your apps and
> projects. Get started today and enter our developer competition.
> http://sdm.link/oxford
> _______________________________________________
> Bacula-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/bacula-devel
>


------------------------------------------------------------------------------
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Phil Stracchino-2
In reply to this post by Phil Stracchino-2
On 03/13/17 10:12, Phil Stracchino wrote:

>
> I'm seeing lots of:
>
> Compiling verify_vol.c
> "xacl.h", line 142: Warning: content hides XACL::content.
> "xacl.h", line 168: Warning: content hides XACL::content.
> "xacl.h", line 194: Warning: content hides XACL::content.
>
>
> when compiling on Solaris 10.
>
> Also in smaller quantities,
>
> Compiling label.c
> "label.c", line 490: Warning: jcr hides DCR::jcr.
> "label.c", line 536: Warning: jcr hides DCR::jcr.
> "label.c", line 573: Warning: jcr hides DCR::jcr.
> 3 Warning(s) detected.
> Compiling lock.c
> "lock.c", line 157: Warning: file hides DEVICE::file.
> "lock.c", line 165: Warning: file hides DEVICE::file.
> "lock.c", line 172: Warning: file hides DEVICE::file.
> "lock.c", line 211: Warning: file hides DEVICE::file.
> "lock.c", line 275: Warning: file hides DEVICE::file.
> "lock.c", line 281: Warning: file hides DEVICE::file.
> "lock.c", line 287: Warning: file hides DEVICE::file.
> "lock.c", line 293: Warning: file hides DEVICE::file.
> "lock.c", line 299: Warning: file hides DEVICE::file.
> "lock.c", line 304: Warning: file hides DEVICE::file.
> 10 Warning(s) detected.


I am seeing successful job completion on Solaris 10u9 compiled with Sun
cc for 'i386-pc-solaris-2.10, solaris 5.10'.  The above warnings appear
to be harmless.  The following patch appears to still be required for
Solaris 10:


--- src/findlib/fstype.c.orig 2015-09-08 07:57:34.000000000 -0400
+++ src/findlib/fstype.c 2015-09-08 07:57:34.954835009 -0400
@@ -278,10 +278,11 @@

  #elif defined(HAVE_SUN_OS)

  #include <sys/types.h>
  #include <sys/stat.h>
+#include <sys/mnttab.h>

  bool fstype(FF_PKT *ff_pkt, char *fs, int fslen)
  {
     /* Solaris has the filesystem type name in the lstat packet */
     bstrncpy(fs, ff_pkt->statp.st_fstype, fslen);
--- src/console/conio.c.orig 2015-08-13 09:52:24.000000000 -0400
+++ src/console/conio.c 2015-09-08 18:30:20.464293207 -0400
@@ -63,11 +63,10 @@
  extern "C" int tgetent(void *, const char *);
  extern "C" int tgetnum(const char *);
  extern "C" char *tgetstr (const char*, char**);
  # Note: the following on older (Solaris 10) systems
  #  may need to be moved to after the #endif
-extern "C" char *tgoto (const char *, int, int);
  #endif
  #elif defined(__sgi)
  extern "C" int tgetent(char *, char *);
  extern "C" int tgetnum(char id[2]);
  extern "C" char *tgetstr(char id[2], char **);
@@ -76,10 +75,12 @@
  extern "C" int tgetent(void *, const char *);
  extern "C" int tgetnum(const char *);
  extern "C" char *tgetstr (const char*, char**);
  extern "C" char *tgoto (const char *, int, int);
  #endif
+extern "C" char *tgoto (const char *, int, int);
+
  #include "func.h"


  /* From termios library */
  #if defined(HAVE_HPUX_OS) || defined(HAVE_AIX_OS)
--- src/cats/cats.h.orig 2015-09-08 18:35:49.663167369 -0400
+++ src/cats/cats.h 2015-08-13 09:52:24.000000000 -0400
@@ -64,11 +64,11 @@

  /* What kind of driver we have */
  typedef enum {
     SQL_DRIVER_TYPE_MYSQL      = 0,
     SQL_DRIVER_TYPE_POSTGRESQL = 1,
-   SQL_DRIVER_TYPE_SQLITE3    = 2,
+   SQL_DRIVER_TYPE_SQLITE3    = 2
  } SQL_DRIVER;


  /* ==============================================================
   *



--
   Phil Stracchino
   Babylon Communications
   [hidden email]
   [hidden email]
   Landline: 603.293.8485

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Kern Sibbald
Hello Phil,

Thanks for the patches and compiler warning output.

I think I have eliminated all the warnings you show below, with one
exception, which is changing the position of:

    extern "C" char *tgoto (const char *, int, int);

As noted in the comments noted above, this is a particularity (bug) in Solaris 10.  If you know some why to key it on Solaris 10 only, I will be happy to take it, otherwise, the change will break more modern (and supported) versions of Solaris.

I will commit these changes sometime today.

Best regards,
Kern


On 03/14/2017 07:12 PM, Phil Stracchino wrote:

> On 03/13/17 10:12, Phil Stracchino wrote:
>> I'm seeing lots of:
>>
>> Compiling verify_vol.c
>> "xacl.h", line 142: Warning: content hides XACL::content.
>> "xacl.h", line 168: Warning: content hides XACL::content.
>> "xacl.h", line 194: Warning: content hides XACL::content.
>>
>>
>> when compiling on Solaris 10.
>>
>> Also in smaller quantities,
>>
>> Compiling label.c
>> "label.c", line 490: Warning: jcr hides DCR::jcr.
>> "label.c", line 536: Warning: jcr hides DCR::jcr.
>> "label.c", line 573: Warning: jcr hides DCR::jcr.
>> 3 Warning(s) detected.
>> Compiling lock.c
>> "lock.c", line 157: Warning: file hides DEVICE::file.
>> "lock.c", line 165: Warning: file hides DEVICE::file.
>> "lock.c", line 172: Warning: file hides DEVICE::file.
>> "lock.c", line 211: Warning: file hides DEVICE::file.
>> "lock.c", line 275: Warning: file hides DEVICE::file.
>> "lock.c", line 281: Warning: file hides DEVICE::file.
>> "lock.c", line 287: Warning: file hides DEVICE::file.
>> "lock.c", line 293: Warning: file hides DEVICE::file.
>> "lock.c", line 299: Warning: file hides DEVICE::file.
>> "lock.c", line 304: Warning: file hides DEVICE::file.
>> 10 Warning(s) detected.
>
> I am seeing successful job completion on Solaris 10u9 compiled with Sun
> cc for 'i386-pc-solaris-2.10, solaris 5.10'.  The above warnings appear
> to be harmless.  The following patch appears to still be required for
> Solaris 10:
>
>
> --- src/findlib/fstype.c.orig 2015-09-08 07:57:34.000000000 -0400
> +++ src/findlib/fstype.c 2015-09-08 07:57:34.954835009 -0400
> @@ -278,10 +278,11 @@
>
>    #elif defined(HAVE_SUN_OS)
>
>    #include <sys/types.h>
>    #include <sys/stat.h>
> +#include <sys/mnttab.h>
>
>    bool fstype(FF_PKT *ff_pkt, char *fs, int fslen)
>    {
>       /* Solaris has the filesystem type name in the lstat packet */
>       bstrncpy(fs, ff_pkt->statp.st_fstype, fslen);
> --- src/console/conio.c.orig 2015-08-13 09:52:24.000000000 -0400
> +++ src/console/conio.c 2015-09-08 18:30:20.464293207 -0400
> @@ -63,11 +63,10 @@
>    extern "C" int tgetent(void *, const char *);
>    extern "C" int tgetnum(const char *);
>    extern "C" char *tgetstr (const char*, char**);
>    # Note: the following on older (Solaris 10) systems
>    #  may need to be moved to after the #endif
> -extern "C" char *tgoto (const char *, int, int);
>    #endif
>    #elif defined(__sgi)
>    extern "C" int tgetent(char *, char *);
>    extern "C" int tgetnum(char id[2]);
>    extern "C" char *tgetstr(char id[2], char **);
> @@ -76,10 +75,12 @@
>    extern "C" int tgetent(void *, const char *);
>    extern "C" int tgetnum(const char *);
>    extern "C" char *tgetstr (const char*, char**);
>    extern "C" char *tgoto (const char *, int, int);
>    #endif
> +extern "C" char *tgoto (const char *, int, int);
> +
>    #include "func.h"
>
>
>    /* From termios library */
>    #if defined(HAVE_HPUX_OS) || defined(HAVE_AIX_OS)
> --- src/cats/cats.h.orig 2015-09-08 18:35:49.663167369 -0400
> +++ src/cats/cats.h 2015-08-13 09:52:24.000000000 -0400
> @@ -64,11 +64,11 @@
>
>    /* What kind of driver we have */
>    typedef enum {
>       SQL_DRIVER_TYPE_MYSQL      = 0,
>       SQL_DRIVER_TYPE_POSTGRESQL = 1,
> -   SQL_DRIVER_TYPE_SQLITE3    = 2,
> +   SQL_DRIVER_TYPE_SQLITE3    = 2
>    } SQL_DRIVER;
>
>
>    /* ==============================================================
>     *
>
>
>


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Martin Simmons
Perhaps HAVE_SUN_OS can be set to a version number based on uname -r in
autoconf/bacula-macros/os.m4?

__Martin


>>>>> On Wed, 15 Mar 2017 11:27:26 +0100, Kern Sibbald said:
>
> Hello Phil,
>
> Thanks for the patches and compiler warning output.
>
> I think I have eliminated all the warnings you show below, with one
> exception, which is changing the position of:
>
>     extern "C" char *tgoto (const char *, int, int);
>
> As noted in the comments noted above, this is a particularity (bug) in Solaris 10.  If you know some why to key it on Solaris 10 only, I will be happy to take it, otherwise, the change will break more modern (and supported) versions of Solaris.
>
> I will commit these changes sometime today.
>
> Best regards,
> Kern
>
>
> On 03/14/2017 07:12 PM, Phil Stracchino wrote:
> > On 03/13/17 10:12, Phil Stracchino wrote:
> >> I'm seeing lots of:
> >>
> >> Compiling verify_vol.c
> >> "xacl.h", line 142: Warning: content hides XACL::content.
> >> "xacl.h", line 168: Warning: content hides XACL::content.
> >> "xacl.h", line 194: Warning: content hides XACL::content.
> >>
> >>
> >> when compiling on Solaris 10.
> >>
> >> Also in smaller quantities,
> >>
> >> Compiling label.c
> >> "label.c", line 490: Warning: jcr hides DCR::jcr.
> >> "label.c", line 536: Warning: jcr hides DCR::jcr.
> >> "label.c", line 573: Warning: jcr hides DCR::jcr.
> >> 3 Warning(s) detected.
> >> Compiling lock.c
> >> "lock.c", line 157: Warning: file hides DEVICE::file.
> >> "lock.c", line 165: Warning: file hides DEVICE::file.
> >> "lock.c", line 172: Warning: file hides DEVICE::file.
> >> "lock.c", line 211: Warning: file hides DEVICE::file.
> >> "lock.c", line 275: Warning: file hides DEVICE::file.
> >> "lock.c", line 281: Warning: file hides DEVICE::file.
> >> "lock.c", line 287: Warning: file hides DEVICE::file.
> >> "lock.c", line 293: Warning: file hides DEVICE::file.
> >> "lock.c", line 299: Warning: file hides DEVICE::file.
> >> "lock.c", line 304: Warning: file hides DEVICE::file.
> >> 10 Warning(s) detected.
> >
> > I am seeing successful job completion on Solaris 10u9 compiled with Sun
> > cc for 'i386-pc-solaris-2.10, solaris 5.10'.  The above warnings appear
> > to be harmless.  The following patch appears to still be required for
> > Solaris 10:
> >
> >
> > --- src/findlib/fstype.c.orig 2015-09-08 07:57:34.000000000 -0400
> > +++ src/findlib/fstype.c 2015-09-08 07:57:34.954835009 -0400
> > @@ -278,10 +278,11 @@
> >
> >    #elif defined(HAVE_SUN_OS)
> >
> >    #include <sys/types.h>
> >    #include <sys/stat.h>
> > +#include <sys/mnttab.h>
> >
> >    bool fstype(FF_PKT *ff_pkt, char *fs, int fslen)
> >    {
> >       /* Solaris has the filesystem type name in the lstat packet */
> >       bstrncpy(fs, ff_pkt->statp.st_fstype, fslen);
> > --- src/console/conio.c.orig 2015-08-13 09:52:24.000000000 -0400
> > +++ src/console/conio.c 2015-09-08 18:30:20.464293207 -0400
> > @@ -63,11 +63,10 @@
> >    extern "C" int tgetent(void *, const char *);
> >    extern "C" int tgetnum(const char *);
> >    extern "C" char *tgetstr (const char*, char**);
> >    # Note: the following on older (Solaris 10) systems
> >    #  may need to be moved to after the #endif
> > -extern "C" char *tgoto (const char *, int, int);
> >    #endif
> >    #elif defined(__sgi)
> >    extern "C" int tgetent(char *, char *);
> >    extern "C" int tgetnum(char id[2]);
> >    extern "C" char *tgetstr(char id[2], char **);
> > @@ -76,10 +75,12 @@
> >    extern "C" int tgetent(void *, const char *);
> >    extern "C" int tgetnum(const char *);
> >    extern "C" char *tgetstr (const char*, char**);
> >    extern "C" char *tgoto (const char *, int, int);
> >    #endif
> > +extern "C" char *tgoto (const char *, int, int);
> > +
> >    #include "func.h"
> >
> >
> >    /* From termios library */
> >    #if defined(HAVE_HPUX_OS) || defined(HAVE_AIX_OS)
> > --- src/cats/cats.h.orig 2015-09-08 18:35:49.663167369 -0400
> > +++ src/cats/cats.h 2015-08-13 09:52:24.000000000 -0400
> > @@ -64,11 +64,11 @@
> >
> >    /* What kind of driver we have */
> >    typedef enum {
> >       SQL_DRIVER_TYPE_MYSQL      = 0,
> >       SQL_DRIVER_TYPE_POSTGRESQL = 1,
> > -   SQL_DRIVER_TYPE_SQLITE3    = 2,
> > +   SQL_DRIVER_TYPE_SQLITE3    = 2
> >    } SQL_DRIVER;
> >
> >
> >    /* ==============================================================
> >     *
> >
> >
> >
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Bacula-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/bacula-devel
>

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bacula Release 7.4.6

Gary R. Schmidt-3
In reply to this post by Kern Sibbald
On 15/03/2017 21:27, Kern Sibbald wrote:

> Hello Phil,
>
> Thanks for the patches and compiler warning output.
>
> I think I have eliminated all the warnings you show below, with one
> exception, which is changing the position of:
>
>      extern "C" char *tgoto (const char *, int, int);
>
> As noted in the comments noted above, this is a particularity (bug) in Solaris 10.  If you know some why to key it on Solaris 10 only, I will be happy to take it, otherwise, the change will break more modern (and supported) versions of Solaris.
>
Just an FYI - that particular bug is fixed in current releases of
Solaris 10.  Update 11 (don't confuse that with *version* 11) has it,
and Oracle supports that (and earlier) versions of S10.

Relevant bits:
$ cat /etc/release
                    Oracle Solaris 10 1/13 s10s_u11wos_24a SPARC
   Copyright (c) 1983, 2013, Oracle and/or its affiliates. All rights
reserved.
                             Assembled 17 January 2013

$ less /usr/include/term.h
#ifdef __STDC__
...
extern char     *tgoto(char *, int, int),
                 *tgetstr(char *, char **),
                 *tigetstr(char *),
                 *termname(void);

...
#else  /* __STDC__ */
...
extern  char    *tparm(), *tgoto(), *tgetstr(), *tigetstr(),
                 *termname();
...
#endif /* __STDC__ */

     Cheers,
         Gary    B-)


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
Loading...